Represent failure with index instead of is_error in data lookup. #88
+25
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterentic-ethernal
requested review from
Leouarz,
markopoloparadox,
fmiguelgarcia and
ToufeeqP
Leouarz
approved these changes
Apr 19, 2024
aterentic-ethernal
force-pushed
the
aterentic/simplify_data_lookup
branch
from
7288bb3
to
f1acf50
Compare
markopoloparadox
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guys, I have missed changing TryFrom implementation for DataLookup last time, this PR should fix that. It also removes is_error field from DataLookup and changes representation to invalid index. Functions that checks validitry of both structs is also added. Wdyt?